[xray] disable securepassword to allow deploy succesfully #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gabo89 Thanks for the PR. We will take this in upcoming releases. |
|
@gabo89 Thanks for the PR , we internally taken this PR and will be released in next upcoming release , can you please quash your commits to single one |
disable securepassword
|
@chukka hello , sure, just pushed the changes required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[artifactory])What this PR does / why we need it:
current rabbitmq for xray doesnt work with RABBITMQ_SECURE_PASSWORD=yes and RABBITMQ_LOAD_DEFINITIONS=yes at the same time, XRAY require RABBITMQ_LOAD_DEFINITIONS , so we need to enforce the RABBITMQ_SECURE_PASSWORD=no since by default the RABBITMQ_SECURE_PASSWORD is set to yes when we set a value on rabbitmq.auth.password!=""
we need to set this value by default so new version can be deployed easily without having to troubleshoot this error
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #havent found a pr that talk about this feature yet
Special notes for your reviewer:
this issue started to happen on the bump of rabbitmq version used xray